[18.0][MIG] fieldservice_agreement: Migration to 18.0#1368
Merged
OCA-git-bot merged 44 commits intoOCA:18.0from Aug 14, 2025
Merged
[18.0][MIG] fieldservice_agreement: Migration to 18.0#1368OCA-git-bot merged 44 commits intoOCA:18.0from
OCA-git-bot merged 44 commits intoOCA:18.0from
Conversation
BhaveshHeliconia
approved these changes
Apr 17, 2025
ivantodorovich
approved these changes
Aug 6, 2025
Contributor
ivantodorovich
left a comment
ivantodorovich
left a comment
There was a problem hiding this comment.
LG, thanks a lot for the work done!
Here are a few suggested changes to improve the UX and modernize the code. Would be great if you can check them out
| name="action_view_service_order" | ||
| type="object" | ||
| class="oe_stat_button" | ||
| icon="fa-map" |
Contributor
There was a problem hiding this comment.
Suggested change
| icon="fa-map" | |
| icon="fa-map" | |
| invisible="service_order_count == 0" |
UX: to be aligned with similar things in Odoo core
https://github.com/odoo/odoo/blob/eef507abe3853f6844fdd7b7bfbc3ff9bedf76ae/addons/purchase/views/purchase_views.xml#L167
Comment on lines
+28
to
+37
| <div class="o_field_widget o_stat_info"> | ||
| <span class="o_stat_value"> | ||
| <field | ||
| name="equipment_count" | ||
| widget="statinfo" | ||
| nolabel="1" | ||
| /> | ||
| </span> | ||
| <span class="o_stat_text">Equipments</span> | ||
| </div> |
Contributor
There was a problem hiding this comment.
Suggested change
| <div class="o_field_widget o_stat_info"> | |
| <span class="o_stat_value"> | |
| <field | |
| name="equipment_count" | |
| widget="statinfo" | |
| nolabel="1" | |
| /> | |
| </span> | |
| <span class="o_stat_text">Equipments</span> | |
| </div> | |
| <field | |
| name="equipment_count" | |
| widget="statinfo" | |
| string="Service Orders" | |
| /> |
let's take the opportunity to modernize this code
| name="action_view_fsm_equipment" | ||
| type="object" | ||
| class="oe_stat_button" | ||
| icon="fa-laptop" |
Contributor
There was a problem hiding this comment.
Suggested change
| icon="fa-laptop" | |
| icon="fa-laptop" | |
| invisible="equipment_count == 0" |
UX: to be aligned with similar things in Odoo core
https://github.com/odoo/odoo/blob/eef507abe3853f6844fdd7b7bfbc3ff9bedf76ae/addons/purchase/views/purchase_views.xml#L167
| type="object" | ||
| name="action_view_agreements" | ||
| class="oe_stat_button" | ||
| icon="fa-folder" |
Contributor
There was a problem hiding this comment.
Suggested change
| icon="fa-folder" | |
| icon="fa-folder" | |
| invisible="agreement_count == 0" |
UX: to be aligned with similar things in Odoo core
https://github.com/odoo/odoo/blob/eef507abe3853f6844fdd7b7bfbc3ff9bedf76ae/addons/purchase/views/purchase_views.xml#L167
Contributor
|
@TB-Ph35 can you check the suggestion from @ivantodorovich ? @rousseldenis can you check this PR too ? 🙏 💚 |
imlopes
approved these changes
Aug 13, 2025
2 tasks
[UPD] README.rst
[UPD] README.rst
* [IMP] fieldservice_agreement [UPD] README.rst
… move views to agreement module 3. improve location heirarchy name construction
[UPD] README.rst
[UPD] README.rst
[IMP] fieldservice_vehicle_stock
[UPD] Update fieldservice_agreement.pot Added translation using Weblate (Portuguese (Brazil)) Added translation using Weblate (Spanish (Chile)) Translated using Weblate (Spanish (Chile)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/es_CL/ Added translation using Weblate (German) Translated using Weblate (German) Currently translated at 6.7% (1 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/de/ Translated using Weblate (German) Currently translated at 26.7% (4 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/de/ Translated using Weblate (German) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/de/ [ADD] Spanish (es) translation Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Translated using Weblate (Spanish) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/es/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Translated using Weblate (Portuguese (Brazil)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/pt_BR/ Added translation using Weblate (Spanish (Argentina)) Translated using Weblate (Spanish (Argentina)) Currently translated at 100.0% (15 of 15 strings) Translation: field-service-12.0/field-service-12.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-12-0/field-service-12-0-fieldservice_agreement/es_AR/
Currently translated at 100.0% (19 of 19 strings) Translation: field-service-14.0/field-service-14.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_agreement/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-14.0/field-service-14.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_agreement/
Currently translated at 100.0% (19 of 19 strings) Translation: field-service-14.0/field-service-14.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-14-0/field-service-14-0-fieldservice_agreement/es_AR/
The `agreement_serviceprofile` dependency has been moved to a glue module `fieldservice_agreement_serviceprofile`.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: field-service-17.0/field-service-17.0-fieldservice_agreement Translate-URL: https://translation.odoo-community.org/projects/field-service-17-0/field-service-17-0-fieldservice_agreement/
TB-Ph35
force-pushed
the
18.0-mig-fieldservice_agreement
branch
from
1b9f1d9 to
1159b5d
Compare
ivantodorovich
approved these changes
Aug 14, 2025
Contributor
ivantodorovich
left a comment
ivantodorovich
left a comment
There was a problem hiding this comment.
LG. Thanks!
Tests are failing due to #1378 (comment)
Not really related to this module.
Should be solved by restarting a new build, normally
Contributor
|
@OCA/field-service-maintainers can we merge this one? 🙏🏻 |
Contributor
|
On my way to merge this fine PR! |
OCA-git-bot
added a commit
that referenced
this pull request
Aug 14, 2025
Contributor
|
@brian10048 your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-1368-by-brian10048-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
Contributor
|
/ocabot merge nobump |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 2ccf803. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.